Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand cfg for operator storage impl #2007

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Expand cfg for operator storage impl #2007

merged 4 commits into from
Jan 5, 2024

Conversation

jdygert-spok
Copy link
Contributor

Previously, trying to build with only e.g. gha feature enabled would not compile.

@sylvestre
Copy link
Collaborator

could you please add a github job to check we don't regress in the future? thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf59584) 30.63% compared to head (16ce2ba) 30.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
+ Coverage   30.63%   30.66%   +0.03%     
==========================================
  Files          51       51              
  Lines       19564    19564              
  Branches     9454     9454              
==========================================
+ Hits         5993     6000       +7     
+ Misses       7905     7902       -3     
+ Partials     5666     5662       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdygert-spok
Copy link
Contributor Author

Sure, which would you rather?

  1. Add single feature variants to existing build matrix
  2. Add job that runs cargo check with each single feature variant manually
  3. Use cargo-all-features to run check-all-features on each combination of features

@jdygert-spok
Copy link
Contributor Author

Seems like maybe 2 makes the most sense here.

@sylvestre
Copy link
Collaborator

sounds good, the matrix github action system should be good enough :)

@sylvestre
Copy link
Collaborator

I guess you saw


Run cargo check --no-default-features --feature gcs
error: unexpected argument '--feature' found

@sylvestre sylvestre merged commit 5d701ea into mozilla:main Jan 5, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants