Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use what we really need from opendal #2118

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Mar 3, 2024

This PR must be merged only after #2114, because this code is based on the parent changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.46%. Comparing base (0cc0c62) to head (0d1ebb4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2118       +/-   ##
===========================================
+ Coverage   30.91%   43.46%   +12.55%     
===========================================
  Files          53       53               
  Lines       20112    20298      +186     
  Branches     9755     9782       +27     
===========================================
+ Hits         6217     8822     +2605     
+ Misses       7922     7678      -244     
+ Partials     5973     3798     -2175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJIOB AJIOB force-pushed the AJIOB/use-what-we-really-need branch from bb64905 to 9895f84 Compare March 3, 2024 11:34
* Migrate `rustls` feature to the `reqwest` feature
@AJIOB AJIOB force-pushed the AJIOB/use-what-we-really-need branch from 9895f84 to 0d1ebb4 Compare March 3, 2024 12:54
@AJIOB AJIOB marked this pull request as ready for review March 3, 2024 12:55
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 73249b9 into mozilla:main Mar 3, 2024
52 checks passed
@AJIOB AJIOB deleted the AJIOB/use-what-we-really-need branch March 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants