Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set User Agent Header for S3 Requests #2137

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Set User Agent Header for S3 Requests #2137

merged 6 commits into from
Mar 25, 2024

Commits on Mar 25, 2024

  1. Set User Agent Header for S3 Requests 

    Closes mozilla#2136.

This PR configures the S3 backend to use a custom HTTP client
which has a user agent header set.

The user agent header enables `sccache` users to write AWS policies to
accept or reject `sccache` requests to an S3 bucket based on their `sccache`
version.
    @ajschmidt8
    ajschmidt8 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9349909 View commit details
    Browse the repository at this point in the history

  2. fix import issue

    @ajschmidt8
    ajschmidt8 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    30b84b2 View commit details
    Browse the repository at this point in the history

  3. use reqwest instead of reqwest/blocking

    @ajschmidt8
    ajschmidt8 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    99fdeb4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into s3-user-agent

    @ajschmidt8
    ajschmidt8 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    535e8ce View commit details
    Browse the repository at this point in the history

  5. mv lines to fn

    @ajschmidt8
    ajschmidt8 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d9251b6 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
    @ajschmidt8 @sylvestre
    ajschmidt8 and sylvestre authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    96f7ed2 View commit details
    Browse the repository at this point in the history