This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Autoclose tags #89
Closed
Autoclose tags #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
force-pushed
the
autoclose-tags
branch
from
15bfc51
to
63d04d7
Compare
Pomax
force-pushed
the
autoclose-tags
branch
from
63d04d7
to
ec6336d
Compare
|
This leaves an issue for |
|
Closing this as I've cherry-picked the changes into my work in progress branch that pairs with the work in Thimble. Cool? |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only took years, but this should close #66 by introducing a new error,
MISMATCHED_CLOSE_TAG_DUE_TO_EARLIER_AUTO_CLOSING, which reports a mismatch between "the code" and "the DOM" when it comes to code like:This will generate an error like:
in which the start tag is
<p>and the end tag is</h2>, but the end tag cannot be resolved due and the element the user thinks it should be in is the<p>element, despite that getting auto-closed in the DOM by that<h1>.As such, rather than a straight forward mismatch to whatever is the parent element according to the DOM, we see a mismatch that is linked to a sibling, not a parent.
This PR also introduces a
MISSING_CLOSING_TAG_NAMEto catch the following error in the HTML:yielding the following error:
This signals that a
</was seen, and that it should match the<p>but that the DOM is already considered closed for that node.