Skip to content

Commit

Permalink
binary-search precision improvement: (#393)
Browse files Browse the repository at this point in the history
+ `===` precise numeric enum check for bias
+ typo fix in comment
  • Loading branch information
GerHobbelt authored and jasonLaster committed Oct 29, 2019
1 parent da4f5a7 commit b47b487
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/binary-search.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function recursiveSearch(aLow, aHigh, aNeedle, aHaystack, aCompare, aBias) {

// The exact needle element was not found in this haystack. Determine if
// we are in termination case (3) or (2) and return the appropriate thing.
if (aBias == exports.LEAST_UPPER_BOUND) {
if (aBias === exports.LEAST_UPPER_BOUND) {
return aHigh < aHaystack.length ? aHigh : -1;
}
return mid;
Expand Down Expand Up @@ -93,7 +93,7 @@ exports.search = function search(aNeedle, aHaystack, aCompare, aBias) {
return -1;
}

// We have found either the exact element, or the next-closest element than
// We have found either the exact element, or the next-closest element to
// the one we are searching for. However, there may be more than one such
// element. Make sure we always return the smallest of these.
while (index - 1 >= 0) {
Expand Down

0 comments on commit b47b487

Please sign in to comment.