Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a consistent return value for sourceContentFor #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewnicols
Copy link

The sourceContentFor function was previously returning null when it
should have returned an exception when the source content was not
provided.

This was discovered whilst debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1556903 and this issue masked that bug.

@coveralls
Copy link

coveralls commented Jun 5, 2019

Pull Request Test Coverage Report for Build 553

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 88.417%

Totals Coverage Status
Change from base Build 550: 0.03%
Covered Lines: 826
Relevant Lines: 913

💛 - Coveralls

The sourceContentFor function was previously returning null when it
should have returned an exception when the source content was not
provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants