Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade syn to 2.0 #1495

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Upgrade syn to 2.0 #1495

merged 2 commits into from
Jun 1, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Mar 20, 2023

No description provided.

@jplatte jplatte requested a review from a team as a code owner March 20, 2023 17:33
@jplatte jplatte requested review from bendk and removed request for a team March 20, 2023 17:33
@badboy
Copy link
Member

badboy commented Mar 20, 2023

With this we would now have both 1.0 and 2.0 as deps here.
m-c is still (obviously) vendoring 1.0. Going to 2.0 here means we will also duplicate everything over there. Unless there are good reasons to just jump ahead I'd prefer if we're not the first doing that.

@jplatte
Copy link
Collaborator Author

jplatte commented Mar 20, 2023

I think having both 1.0 and 2.0 in the tree will soon be unavoidable. dtolnay already upgraded his own (big) crates like thiserror and serde_derive.

But it's not critical to have this merged soon.

@badboy
Copy link
Member

badboy commented Mar 21, 2023

I think having both 1.0 and 2.0 in the tree will soon be unavoidable. dtolnay already upgraded his own (big) crates like thiserror and serde_derive.

But it's not critical to have this merged soon.

yeah, we will have to figure this out over on the m-c side eventually.

@jplatte
Copy link
Collaborator Author

jplatte commented May 25, 2023

Has this been figured out on the m-c side? Attribute parsing is a bit more convenient in syn 2.0, so it would be nice to have that new API when working on the proc-macro frontend.

edit: Judging by this being the only syn package in m-c's Cargo.lock, nothing has changed.

@badboy
Copy link
Member

badboy commented May 25, 2023

Has this been figured out on the m-c side? Attribute parsing is a bit more convenient in syn 2.0, so it would be nice to have that new API when working on the proc-macro frontend.

edit: Judging by this being the only syn package in m-c's Cargo.lock, nothing has changed.

I'll make myself a todo to find some people to figure this out next week.

Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the OK to land syn v2 in m-c as well, so we can now land this. I'll work on a followup to upgrade askama and some others as well to reduce the number of crates on syn v1

@badboy badboy removed the request for review from bendk June 1, 2023 08:10
@badboy
Copy link
Member

badboy commented Jun 1, 2023

@jplatte looks like this has some merge conflicts (but GitHub is acting up and not even letting me do the usual resolving in the UI?). Can you rebase this PR?

@badboy badboy mentioned this pull request Jun 1, 2023
@badboy badboy merged commit 1851fef into mozilla:main Jun 1, 2023
5 checks passed
@jplatte jplatte deleted the syn2 branch June 1, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants