Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localizedDescription support to swift errors. #2116

Merged
merged 1 commit into from
May 18, 2024

Conversation

mhammond
Copy link
Member

Also some extra error string semantics tests for kotlin.

Fixes #2110

@mhammond mhammond requested a review from linabutler May 18, 2024 14:53
@mhammond mhammond requested a review from a team as a code owner May 18, 2024 14:53
@mhammond mhammond requested review from bendk and removed request for a team May 18, 2024 14:53
@mhammond mhammond changed the title Add localizedError support to swift errors. Add localizedDescription support to swift errors. May 18, 2024
Also some extra error string semantics tests for kotlin.

Fixes mozilla#2110
Copy link
Member

@linabutler linabutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, I love it! Great that String(reflecting:) works like a charm.

Thanks, @mhammond!

@mhammond mhammond merged commit aa338cc into mozilla:main May 18, 2024
5 checks passed
@mhammond mhammond deleted the localized-error branch May 18, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift errors don't provide localizedDescription
2 participants