Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root.VTTCue should fall back to VVTCue if not set #353

Merged
merged 1 commit into from
Nov 16, 2016
Merged

root.VTTCue should fall back to VVTCue if not set #353

merged 1 commit into from
Nov 16, 2016

Conversation

coolheinze
Copy link
Contributor

VTTCue is never null so it always fell back, which doesn't work on some browsers.

@coolheinze
root.VTTCue should fall back to VVTCue if not set
e742965 
VTTCue is never null so it always fell back, which doesn't work on some browsers.
rillian
rillian approved these changes Nov 16, 2016
View reviewed changes
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@rillian rillian merged commit 86d357c into mozilla:master Nov 16, 2016
@coolheinze coolheinze mentioned this pull request Nov 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rillian rillian rillian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolheinze @rillian