Promote the new --devtools command line argument and link to debuggin…

…g online documentation
mozilla · Sep 6, 2022 · 1f14786 · 1f14786
1 parent 94989fa
commit 1f14786
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/cmd/run.js b/src/cmd/run.js
@@ -93,6 +93,7 @@ export default async function run(
     target,
     args,
     firefoxPreview = [],
+    verbose = false,
     // Android CLI options.
     adbBin,
     adbHost,
@@ -177,6 +178,7 @@ export default async function run(
       customPrefs,
       browserConsole,
       devtools,
+      verbose,
       preInstall,
 
       // Firefox runner injected dependencies.

diff --git a/src/extension-runners/firefox-desktop.js b/src/extension-runners/firefox-desktop.js
@@ -34,6 +34,7 @@ type FirefoxDesktopSpecificRunnerParams = {|
   customPrefs?: FirefoxPreferences,
   browserConsole: boolean,
   devtools: boolean,
+  verbose: boolean,
   firefoxBinary: string,
   preInstall: boolean,
 
@@ -214,6 +215,7 @@ export class FirefoxDesktopExtensionRunner {
     const {
       browserConsole,
       devtools,
+      verbose,
       extensions,
       firefoxBinary,
       preInstall,
@@ -243,6 +245,8 @@ export class FirefoxDesktopExtensionRunner {
       firefoxBinary,
       binaryArgs,
       extensions,
+      verbose,
+      devtools,
     });
 
     this.runningInfo.firefox.on('close', () => {

diff --git a/src/firefox/index.js b/src/firefox/index.js
@@ -90,6 +90,8 @@ export type FirefoxRunOptions = {
   binaryArgs?: Array<string>,
   args?: Array<any>,
   extensions: Array<Extension>,
+  devtools: boolean,
+  verbose: boolean,
 };
 
 /*
@@ -103,6 +105,8 @@ export async function run(
     firefoxBinary,
     binaryArgs,
     extensions,
+    devtools,
+    verbose,
   }: FirefoxRunOptions = {}
 ): Promise<FirefoxInfo> {
 
@@ -164,9 +168,13 @@ export async function run(
     throw error;
   });
 
-  log.info(
-    'Use --verbose or open Tools > Web Developer > Browser Console ' +
-    'to see logging');
+  if (!verbose && !devtools) {
+    log.info('Use --verbose or --devtools to see logging');
+  }
+  if (devtools) {
+    log.info('More info about WebExtension debugging:');
+    log.info('https://extensionworkshop.com/documentation/develop/debugging/');
+  }
 
   firefox.stderr.on('data', (data) => {
     log.debug(`Firefox stderr: ${data.toString().trim()}`);