Promote the new --devtools command line argument and link to debuggin…

…g online documentation
mozilla · Sep 1, 2022 · 81a0f49 · 81a0f49
1 parent 94989fa
commit 81a0f49
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/cmd/run.js b/src/cmd/run.js
@@ -93,6 +93,7 @@ export default async function run(
     target,
     args,
     firefoxPreview = [],
+    verbose = false,
     // Android CLI options.
     adbBin,
     adbHost,
@@ -165,6 +166,7 @@ export default async function run(
     startUrl,
     args,
     desktopNotifications,
+    verbose,
   };
 
   if (!target || target.length === 0 || target.includes('firefox-desktop')) {

diff --git a/src/extension-runners/firefox-desktop.js b/src/extension-runners/firefox-desktop.js
@@ -214,6 +214,7 @@ export class FirefoxDesktopExtensionRunner {
     const {
       browserConsole,
       devtools,
+      verbose,
       extensions,
       firefoxBinary,
       preInstall,
@@ -243,6 +244,8 @@ export class FirefoxDesktopExtensionRunner {
       firefoxBinary,
       binaryArgs,
       extensions,
+      verbose,
+      devtools,
     });
 
     this.runningInfo.firefox.on('close', () => {

diff --git a/src/firefox/index.js b/src/firefox/index.js
@@ -103,6 +103,8 @@ export async function run(
     firefoxBinary,
     binaryArgs,
     extensions,
+    devtools,
+    verbose,
   }: FirefoxRunOptions = {}
 ): Promise<FirefoxInfo> {
 
@@ -164,9 +166,13 @@ export async function run(
     throw error;
   });
 
-  log.info(
-    'Use --verbose or open Tools > Web Developer > Browser Console ' +
-    'to see logging');
+  if (!verbose && !devtools) {
+    log.info('Use --verbose or --devtools to see logging');
+  }
+  if (devtools) {
+    log.info("More info about WebExtension debugging:");
+    log.info("https://extensionworkshop.com/documentation/develop/debugging/");
+  }
 
   firefox.stderr.on('data', (data) => {
     log.debug(`Firefox stderr: ${data.toString().trim()}`);