Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sign-addon dependency #2737

Closed
willdurand opened this issue Apr 25, 2023 · 4 comments · Fixed by #2880
Closed

Remove sign-addon dependency #2737

willdurand opened this issue Apr 25, 2023 · 4 comments · Fixed by #2880

Comments

@willdurand
Copy link
Member

Once we make the submission API the default, we can remove sign-addon and the old signing code.

@lsim
Copy link

lsim commented Jun 6, 2023

Any thoughts on when this task might get released? It's tripping up my CI audit.

@ioanarusiczki
Copy link

@willdurand

I uploaded using web-ext 7.8.0 listed and unlisted versions

on AMO Dev: https://addons-dev.allizom.org/en-US/developers/addon/38a04afb6f9f4ed39123/versions
on AMO Stage: https://addons.allizom.org/en-US/developers/addon/web-ext-submission-on-amode2/versions

During the process I don't think I've noticed changes. I did have errors after the upload when I did not add metadata for listed versions in metadata.json, but I'm sure that's expected to happen.

When I'm at the signing step, I exit it with Ctrl+C , this would be the last step of the web-ext submission:

signstep

@willdurand
Copy link
Member Author

I guess we're good then?

@ioanarusiczki
Copy link

@willdurand Yes, I really wish I had more time to explore but there's too many issues on the other repos.

Marking this verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants