feat: remove sign-addon #2880
Merged
feat: remove sign-addon #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
remove-sign-addon
branch
3 times, most recently
from
82f71fe
to
b2e08d4
Compare
|
dat lockfile diff 🥵 
|
|
@willdurand I looked into the functional test failure and while I was there I thought to also rebase this PR to resolve the conflicts it got in the meantime, I'm about to push an update to this existing PR and branch to confirm that the functional tests will be passing when running as part of the CI job as they did when I was executing them locally (and that I didn't missed any other tests failing while we remove the sign-addon dependency). |
rpl
force-pushed
the
remove-sign-addon
branch
from
b2e08d4
to
f212056
Compare
… test to pass with the submit-addon API
rpl
force-pushed
the
remove-sign-addon
branch
from
f212056
to
b2cf0d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2880 +/- ##
==========================================
- Coverage 99.48% 99.31% -0.18%
==========================================
Files 32 32
Lines 1761 1753 -8
==========================================
- Hits 1752 1741 -11
- Misses 9 12 +3
☔ View full report in Codecov by Sentry. |
2 tasks
|
Excellent, thanks! |
rpl
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2737