feat: remove --id flag on web-ext sign #3126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3124
As per #2458 (comment), we require the add-on ID to be specified in the manifest.
New MV2 add-on, no ID in the manifest
Add-on ID is generated by AMO, a message is printed to update the
manifest.json
file:Add-on submitted successfully.
Existing MV2 add-on, no ID in the manifest
An error is thrown by web-ext:
New MV2 add-on, ID in the manifest
Add-on submitted successfully.
Existing MV2 add-on, ID in the manifest
Add-on submitted successfully.
New MV3 add-on, no ID in the manifest
An error is thrown by web-ext:
New MV3 add-on, ID in the manifest
Add-on submitted successfully.