Initial pass at i18n #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use |
|
It would be fine to merge the code right away. It could always get refactored later if needed. |
|
You are welcome to merge my pulls and I'll be happy to merge yours. I'm just trying to work in a way that allows you to easily review what I've done. |
|
I don’t mind reviewing your changes in Pull Requests + giving you feedback before merging new code. I’d be happy to help out with that when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dynamic language detection so our non-English users can enjoy Kuiq too.
Not sure where the code belongs so suggestions and refactorings are welcome.