Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n issues + Refactorings #6

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

AndyObtiva
Copy link
Collaborator

Hi,

I couldn't resist making changes sooner than the weekend. In addition to fixing all i18n issues and making translations work in all tabs, I simplified the look and feel by ditching big labels in favor of groups, which are more conventional in desktop apps. Desktop applications usually have a simpler more platform conformant look than web apps, unlike web apps, which usually have a highly custom look.

Change log:

  • Fix issue with labels not being big enough for i18n text in dashboard
  • Replace use of graphical_label with group because that is more conventional in desktop applications
  • Fix i18n issues in Retries/Scheduled tables / Refactor extract Kuiq::Control code to I18n & Kernel to allow writing Glimmer custom control code the normal way for better maintainability
  • Optimize i18n code
  • Refresh time dynamically based on polling interval

Screenshots:

In French:

Screenshot 2023-11-27 at 9 08 46 PM Screenshot 2023-11-27 at 9 08 58 PM Screenshot 2023-11-27 at 9 09 05 PM

In English

Screenshot 2023-11-27 at 8 47 04 PM Screenshot 2023-11-27 at 8 47 24 PM Screenshot 2023-11-27 at 8 47 30 PM

@mperham mperham merged commit 1d3813b into mperham:main Nov 28, 2023
1 check failed
@AndyObtiva AndyObtiva deleted the development branch November 29, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants