Skip to content

Commit

Permalink
Merge pull request kubernetes#3892 from romana/romana-networking-update
Browse files Browse the repository at this point in the history
Version and validation updates for romana networking.
  • Loading branch information
justinsb committed Nov 22, 2017
2 parents be898c1 + 04ef7ee commit 1b58585
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 11 deletions.
4 changes: 2 additions & 2 deletions pkg/apis/kops/validation/legacy.go
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,9 @@ func ValidateCluster(c *kops.Cluster, strict bool) *field.Error {
}
}

if kubernetesRelease.LT(semver.MustParse("1.6.0")) {
if kubernetesRelease.LT(semver.MustParse("1.7.0")) {
if c.Spec.Networking != nil && c.Spec.Networking.Romana != nil {
return field.Invalid(fieldSpec.Child("Networking"), "romana", "romana networking is not supported with kubernetes versions 1.5 or lower")
return field.Invalid(fieldSpec.Child("Networking"), "romana", "romana networking is not supported with kubernetes versions 1.6 or lower")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ spec:
effect: NoSchedule
containers:
- name: romana-daemon
image: quay.io/romana/daemon:v2.0-preview.2
image: quay.io/romana/daemon:v2.0.0
imagePullPolicy: Always
resources:
requests:
Expand Down Expand Up @@ -170,7 +170,7 @@ spec:
effect: NoSchedule
containers:
- name: romana-listener
image: quay.io/romana/listener:v2.0-preview.2
image: quay.io/romana/listener:v2.0.0
imagePullPolicy: Always
resources:
requests:
Expand All @@ -185,6 +185,8 @@ metadata:
name: romana-agent
namespace: kube-system
spec:
updateStrategy:
type: RollingUpdate
template:
metadata:
labels:
Expand All @@ -200,7 +202,7 @@ spec:
effect: NoSchedule
containers:
- name: romana-agent
image: quay.io/romana/agent:v2.0-preview.2
image: quay.io/romana/agent:v2.0.0
imagePullPolicy: Always
resources:
requests:
Expand All @@ -213,6 +215,10 @@ spec:
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: NODEIP
valueFrom:
fieldRef:
fieldPath: status.hostIP
args:
- --service-cluster-ip-range={{ .ServiceClusterIPRange }}
securityContext:
Expand Down Expand Up @@ -299,7 +305,7 @@ spec:
effect: NoSchedule
containers:
- name: romana-aws
image: quay.io/romana/aws:v2.0-preview.2
image: quay.io/romana/aws:v2.0.0
imagePullPolicy: Always
resources:
requests:
Expand Down Expand Up @@ -328,7 +334,7 @@ spec:
effect: NoSchedule
containers:
- name: romana-vpcrouter
image: quay.io/romana/vpcrouter-romana-plugin
image: quay.io/romana/vpcrouter-romana-plugin:1.1.12
imagePullPolicy: Always
resources:
requests:
Expand Down
8 changes: 4 additions & 4 deletions upup/pkg/fi/cloudup/bootstrapchannelbuilder.go
Original file line number Diff line number Diff line change
Expand Up @@ -598,18 +598,18 @@ func (b *BootstrapChannelBuilder) buildManifest() (*channelsapi.Addons, map[stri

if b.cluster.Spec.Networking.Romana != nil {
key := "networking.romana"
version := "v2.0-preview.3"
version := "v2.0.0"

{
location := key + "/k8s-1.6.yaml"
id := "k8s-1.6"
location := key + "/k8s-1.7.yaml"
id := "k8s-1.7"

addons.Spec.Addons = append(addons.Spec.Addons, &channelsapi.AddonSpec{
Name: fi.String(key),
Version: fi.String(version),
Selector: networkingSelector,
Manifest: fi.String(location),
KubernetesVersion: ">=1.6.0",
KubernetesVersion: ">=1.7.0",
Id: id,
})
manifests[key+"-"+id] = "addons/" + location
Expand Down

0 comments on commit 1b58585

Please sign in to comment.