-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom owner and repo inputs #78
add custom owner and repo inputs #78
Conversation
Please double check my work. I don't often work GitHub actions in this language. I originally missed some things as I only changed the I have confirmed that this does allow commenting on a PR in another repo, so hopefully you can get this merged. I'm happy to clean up any code, but I have turned off "allow edits by maintainers" as I will be using this branch in my workflows. |
@ReenigneArcher That looks pretty good to me. It would probably be good to add a quick unit test for this. You'd need to make
Since you said you're not as familiar with GitHub Actions I can merge and add for you after. Just let me know. |
@mshick I added the test (hopefully correctly). Please let me know if something isn't right or should be changed before merging. I'm familiar with GitHub actions, but this is my first time playing with typescript. I've used Javascript a bit, but have not done any unit testing there yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work adding the test. A few more suggestions. Like I mention, be sure to get the latest changes from main
for the comments to make sense.
Did I miss something in the test? I'm not seeing the reason for the failure. |
@ReenigneArcher No, it's the perms... I haven't figured out how to get write perms for public forks. I'll test locally and merge if everything looks good. |
Ah, so, a few things going on. Some are just general updates to the tests. The main reason yours is failing is that you're not setting a message in your test, adding this line I'm going to go ahead and merge your PR and I'll make the other updates myself. Thanks for the contribution! I'll have a new version out soon. |
@all-contributors please add @ReenigneArcher for code |
I've put up a pull request to add @ReenigneArcher! 🎉 |
This PR adds the ability to specify the repo owner and/or repo name in order to create a comment in another repo.