fix(WebSocket): add "server.close()" method #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
fix/ws-server-close
branch
from
22a705d
to
3c17eb1
Compare
kettanaito
force-pushed
the
fix/ws-server-close
branch
from
b2b3140
to
f2e5376
Compare
Released: v0.26.11 🎉This has been released in v0.26.11! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows closing the actual server connection by adding a new
server.close()method.Todo
server.addEventListener('close')to know when the original server closes the connection.server.close()isn't that nice. Consider a different logic? For example, properly awaiting the close frame and then doing theserver.connect()would solve this.