Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use windmc in distutils for Python 3 #5659

Closed
joankaradimov opened this issue Jul 29, 2019 · 5 comments
Closed

Use windmc in distutils for Python 3 #5659

joankaradimov opened this issue Jul 29, 2019 · 5 comments
Labels

Comments

@joankaradimov
Copy link
Contributor

While trying to build the pywin32 package on Python 3, I get this error:

error: unknown file type '.mc' (from 'win32/src/PerfMon/PyPerfMsgs.mc')

It appears that the Python 2 package patches distutils and handles .mc files via windmc from binutils. Python 3, however, does not.

@lazka lazka added the python label Jul 29, 2019
@lazka
Copy link
Member

lazka commented Jul 29, 2019

Sounds like a good idea.

@Alexpux
Copy link
Member

Alexpux commented Jul 30, 2019

done by @240d923

@Alexpux Alexpux closed this as completed Jul 30, 2019
@lazka
Copy link
Member

lazka commented Jul 30, 2019

@Alexpux what about this part of the py2 patch

             ext_normcase = os.path.normcase(ext)
             if ext_normcase in ['.rc','.res']:
                 ext = ext_normcase
-            if ext not in (self.src_extensions + ['.rc','.res']):
+            if ext not in (self.src_extensions + ['.rc', '.res', '.mc']):
                 raise UnknownFileError, \
                       "unknown file type '%s' (from '%s')" % \
                       (ext, src_name)

Is it not needed?

@Alexpux
Copy link
Member

Alexpux commented Jul 30, 2019

oh forgot about it. Will fix

@Alexpux
Copy link
Member

Alexpux commented Jul 30, 2019

Done in 1912c5b and 913e8e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants