Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gallery inconsistencies #2647

Merged
merged 2 commits into from
Jun 24, 2024
Merged

refactor: gallery inconsistencies #2647

merged 2 commits into from
Jun 24, 2024

Conversation

mudler
Copy link
Owner

@mudler mudler commented Jun 24, 2024

Description

This PR fixes few inconsistencies in the gallery code:

  • moves pkg/gallery inside core/ as it is a core component (!)
  • moves the Galleries config inside the config package (as it is used by the user to supply the gallery repositories which should be used) - so lets be consistent and move the structures which are configurable by the user in config

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 0188d9a
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/667972cf2952aa00085f3c75
😎 Deploy Preview https://deploy-preview-2647--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler mudler changed the title refactor: gallery consistency refactor: gallery inconsistencies Jun 24, 2024
@mudler mudler force-pushed the gallery_consistency branch 5 times, most recently from 95ea51f to f57a53e Compare June 24, 2024 10:32
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@dave-gray101
Copy link
Collaborator

This is somewhat of a hypothetical still - but should we consider merging the core/gallery folder away into components under core/config and core/services? I've got to think about this for a few more minutes myself... but from my memory most of the code here is either related to the conversion between gallery configs and backend configs (which could potentially belong under config) and installation / download, which probably belongs within core/services/gallery.go?

@mudler
Copy link
Owner Author

mudler commented Jun 24, 2024

This is somewhat of a hypothetical still - but should we consider merging the core/gallery folder away into components under core/config and core/services? I've got to think about this for a few more minutes myself... but from my memory most of the code here is either related to the conversion between gallery configs and backend configs (which could potentially belong under config) and installation / download, which probably belongs within core/services/gallery.go?

mmm good point yes, probably only request.go should be moved around as its re-used in many parts of the code. Maybe even schema?
But I'm thinking probably we should actually have something like core/services/gallery, core/services/... at this point

@mudler mudler merged commit a181dd0 into master Jun 24, 2024
38 checks passed
@mudler mudler deleted the gallery_consistency branch June 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants