Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][slider] Move palette styles to the bottom #41676

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 27, 2024

Issue: https://mui.com/material-ui/, see #41201 (comment)

image

I don't have time to dig down to the root cause at the moment. This is a quick fix to get rid of the styles generation error.

After: https://deploy-preview-41676--material-ui.netlify.app/material-ui/

image

@siriwatknp siriwatknp added component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 27, 2024
@mui-bot
Copy link

mui-bot commented Mar 27, 2024

Netlify deploy preview

https://deploy-preview-41676--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 40af0c9

@siriwatknp siriwatknp merged commit 1b96fa6 into mui:next Apr 2, 2024
20 of 21 checks passed
@oliviertassinari
Copy link
Member

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

@siriwatknp
Copy link
Member Author

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

I agree. It's hard for me to let go too but I don't have resource to get into this right now.

I will create an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants