Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Improve Twitter OG:image #41860

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 11, 2024

Revert #32536, since we have #41188 now 👌. I wanted to tweet to celebrate this change as it's a nice DX improvement, but got blocked by this.

Before
SCR-20240411-pgxo

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product labels Apr 11, 2024
@mui-bot
Copy link

mui-bot commented Apr 11, 2024

Netlify deploy preview

https://deploy-preview-41860--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b674117

@oliviertassinari oliviertassinari added the cherry-pick The PR was cherry-picked from the next branch label Apr 19, 2024
@oliviertassinari oliviertassinari merged commit 1614283 into mui:next Apr 19, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the og-image-twitter branch April 19, 2024 22:00
@oliviertassinari oliviertassinari added needs cherry-pick The PR should be cherry-picked to master after merge and removed cherry-pick The PR was cherry-picked from the next branch labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants