Fix fetch query preview

[bytasv]

• Follow up for Improve preview feedback in fetch query #1153 (comment)

• Kept only logic which checks if untransformed data is undefined

• Rendering undefined as a returned value in JsonView

One thing I'm not sure if it's fine - when api returns empty object, preview just show Object which to me seems a bit confusing (I'd expect maybe to see Object { }.

It seems that this is effect of using custom nodeRenderer, if I removed nodeRenderer, I get result close to what I expect to see in console:

And with empty object:

I kept this part as is, lemme know if you think we should change it as well

[render]

Your Render PR Server URL is https://toolpad-pr-1165.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cd6gjuaen0hsgl6sno1g.

[Janpot]

It seems that this is effect of using custom nodeRenderer, if I removed nodeRenderer, I get result close to what I expect to see in console:

I believe this was originally done to improve how that global scope explorer looks (It was the first thing we used this JsonView for I think). When just used as an output it doesn't work well.

I think if we redesign a little bit how the global scope explorer works, we can remove this nodeRenderer. By redesign I mean: instead of just showing a json view for the whole object, we render each global variable with a JsonView on its own. But we can do that in follow-up.

Just added one comment about what to show in the preview, other than that, I think this lgtm

[Janpot]

Just an idea, but would it make sense to both show the JsonView with undefined and the Alert? Basically we'd always show the exact JSON output, but in some cases we show an extra warning alongside of it.

[bytasv]

You mean this alert? 👇 (sorry for code screenshot 🙈 )

Would you like to display that only when undefined is returned or some other conditions as well?

[Janpot]

The way I was imagining it in #1083 is:

• We always show a JsonView, even if the data is undefined, and we make sure the JsonView can show undefined instead of nothing.

The stretch goals of #1083 would be

• In the transform editor tab, add more text and/or a docs link with some more information about what it's for and what code it expects
• When the transformed data is undefined. show a warning (above or under the JsonView) that points out that there's a potential issue with the transform function.

These last two are nice-to-haves IMO and probably require a bit more thinking about the content

[bytasv]

IMO all suggestions are easily doable right now. I could make the changes and just render same text that I've used before without auto tab switching. I can also add a link to a tab on transform word so user could quickly jump into that if needed

[bytasv]

I think if we redesign a little bit how the global scope explorer works, we can remove this nodeRenderer. By redesign I mean: instead of just showing a json view for the whole object, we render each global variable with a JsonView on its own. But we can do that in follow-up.

Are you talking about this part:

The logic would be that we iterate through globalScope keys and render each using JsonView without nodeRenderer defined?

[bytasv]

Added this warning back, but only if transform returns undefined, @Janpot lemme know if I understood your suggestions correctly

[Janpot]

👍 looks good