[account] Export AccountUserDetails component
#4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into enh/account-3
…into enh/account-3
bharatkashyap
added
docs
bharatkashyap
changed the title
userDetailsContainer slotAccountUserDetails component
github-actions
bot
added
the
PR: out-of-date
7 tasks
apedroferreira
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Looks great!
Other than what I added in #4181 just added some opinions on naming and docs feedback.
| slotProps={{ | ||
| userDetailsContainer: { |
There was a problem hiding this comment.
What about calling it just userDetails?
| }), | ||
| slots: PropTypes.shape({ | ||
| menuItems: PropTypes.elementType, | ||
| content: PropTypes.elementType, |
There was a problem hiding this comment.
Maybe the name content is too generic? But it's just my opinion, I don't mind it.
| display: 'flex', | ||
| flexDirection: 'row', | ||
| justifyContent: 'space-between', | ||
| padding: theme.spacing(2), |
There was a problem hiding this comment.
Is using a simple 2 here not the same thing? (not sure though)
| By passing a custom component to the `userDetailsContainer` slot, you can override the section which displays the signed-in user's details. The custom component receives a `session` prop which contains the current authentication session: | ||
|
|
||
| ```tsx | ||
| // ... |
There was a problem hiding this comment.
This example doesn't immediately make sense to me: where is the CustomSession being used?
bharatkashyap
changed the title
AccountUserDetails component AccountUserDetails component
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Account/>#4226To Do
useSession()hook for user to be able to extend it