Skip to content

Commit

Permalink
slirp: Generalizing and neutralizing ARP code
Browse files Browse the repository at this point in the history
Basically, this patch replaces "arp" by "resolution" every time "arp"
means "mac resolution" and not specifically ARP.

This prepares for IPv6 support.

Signed-off-by: Guillaume Subiron <maethor@subiron.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
Guillaume Subiron authored and jasowang committed Feb 4, 2016
1 parent 86c9e1e commit fc3779a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion slirp/mbuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ m_get(Slirp *slirp)
m->m_len = 0;
m->m_nextpkt = NULL;
m->m_prevpkt = NULL;
m->arp_requested = false;
m->resolution_requested = false;
m->expiration_date = (uint64_t)-1;
end_error:
DEBUG_ARG("m = %p", m);
Expand Down
2 changes: 1 addition & 1 deletion slirp/mbuf.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ struct mbuf {
int m_len; /* Amount of data in this mbuf */

Slirp *slirp;
bool arp_requested;
bool resolution_requested;
uint64_t expiration_date;
/* start of dynamic buffer area, must be last element */
union {
Expand Down
4 changes: 2 additions & 2 deletions slirp/slirp.c
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ int if_encap(Slirp *slirp, struct mbuf *ifm)
struct ethhdr *reh = (struct ethhdr *)arp_req;
struct arphdr *rah = (struct arphdr *)(arp_req + ETH_HLEN);

if (!ifm->arp_requested) {
if (!ifm->resolution_requested) {
/* If the client addr is not known, send an ARP request */
memset(reh->h_dest, 0xff, ETH_ALEN);
memcpy(reh->h_source, special_ethaddr, ETH_ALEN - 4);
Expand All @@ -812,7 +812,7 @@ int if_encap(Slirp *slirp, struct mbuf *ifm)
rah->ar_tip = iph->ip_dst.s_addr;
slirp->client_ipaddr = iph->ip_dst;
slirp_output(slirp->opaque, arp_req, sizeof(arp_req));
ifm->arp_requested = true;
ifm->resolution_requested = true;

/* Expire request and drop outgoing packet after 1 second */
ifm->expiration_date = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + 1000000000ULL;
Expand Down

0 comments on commit fc3779a

Please sign in to comment.