Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify integrity of downloaded libraries #312

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

wiktorn
Copy link

@wiktorn wiktorn commented Feb 22, 2020

  • split fetch_unpack into separate fetch and unpack functions
  • provide fetch_unpack using above two for backward compatibility
  • add build_simple_check that uses separate fetch/unpack functions and checks SHA256 after fetching. This is provided as new function, as the interface has changed (instead of version it takes variable prefix) so old one is left for backwards compatibility
  • change all build_* to use build_simple_check or fetch/unpack and check SHA256 depending on previous approach
  • change variables for OPENSSL_* so it's using standard variables (OPENSSL_VERSION and OPENSSL_HASH instead of OPENSSL_DOWNLOAD_URL, OPENSSL_ROOT and OPENSSL_HASH)

Closes: #308

@wiktorn
Copy link
Author

wiktorn commented Feb 22, 2020

And also I've made some changes according to https://www.shellcheck.net/ (at least, where I was already changing something)

@wiktorn
Copy link
Author

wiktorn commented Feb 22, 2020

Should I care about these two failed jobs? It looks to me that it's something broken in Homebrew?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library builders do not verify integrity of downloaded files
1 participant