This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
make multiaddr-net more pluggable #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| maddrParsers[maname] = mp | ||
| } | ||
|
|
||
| func ParseTcpNetAddr(a net.Addr) (ma.Multiaddr, error) { |
There was a problem hiding this comment.
Do the Parse* methods need to be public? If so, tests would be awesome!
ghost
mentioned this pull request
|
This gets closer to the modularity described in #7 but doesnt yet go all the way due to the complexity of refactoring every package that uses this |
| addrParsers = make(map[string]AddrParser) | ||
| maddrParsers = make(map[string]MaddrParser) | ||
|
|
||
| RegisterAddressType(tcpAddrSpec) |
There was a problem hiding this comment.
Would it make more sense for the default specs to live in here rather than convert.go?
There was a problem hiding this comment.
hrm... you might be right there. code organization is hard
|
🐴 LGTM |
| ) | ||
|
|
||
| type AddrParser func(a net.Addr) (ma.Multiaddr, error) | ||
| type MaddrParser func(ma ma.Multiaddr) (net.Addr, error) |
There was a problem hiding this comment.
instead of these two functions, which are named a bit confusingly, either:
type NetAddr2MAddr func(a net.Addr) (ma.Multiaddr, error)
type MAddr2NetAddr func(ma ma.Multiaddr) (net.Addr, error)
// or
type FromNetAddr func(a net.Addr) (ma.Multiaddr, error)
type ToNetAddr func(ma ma.Multiaddr) (net.Addr, error)
// or even
type NetCodec struct {
FromNet func(a net.Addr) (ma.Multiaddr, error)
ToNet func(a net.Addr) (ma.Multiaddr, error)
}
var TCPNetCodec = NetCodec{}
TCPNetCodec.FromNet = func ...
TCPNetCodec.ToNet = func ...
|
@jbenet addressed your feedback |
|
thanks for addressing the comments ❤️ ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiaddr net needed some more modularity. I've started on this here.