Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS protocol #153

Merged

Conversation

carpawell
Copy link
Contributor

Added TLS protocol. There are plenty of applications of TLS protocol not in the context of using it with http or ws(e.g. in gPRC), so it seems logical to add it. Code for it was taken from multicodec repo.

There is multiformats/multiaddr#109 PR that suggests adding TLS protocol, mark https and wss protocols as deprecated and start using /tls/http and /tls/ws instead.

@carpawell carpawell marked this pull request as ready for review May 26, 2021 13:42
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're not simply removing /https, this seems reasonable. Let me quickly get a signoff from other libp2p devs but then I think we can probably just merge it.

multiaddr_test.go Outdated Show resolved Hide resolved
multiaddr_test.go Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the multiformats perspective. I can not comment on the Go side.

I think we should wait for a sign-off by @marten-seemann as well to ensure this is consistent long term with QUIC and HTTP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants