Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add /p2p-stardust #78

Merged
merged 1 commit into from
Jan 25, 2019
Merged

feat: Add /p2p-stardust #78

merged 1 commit into from
Jan 25, 2019

Conversation

mkg20001
Copy link
Contributor

This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference

mkg20001 added a commit to mkg20001/js-mafmt that referenced this pull request Jan 11, 2019
@mkg20001
feat: Add /p2p-stardust
3c5dd17 
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference

Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
This was referenced Jan 11, 2019
Merged
Closed
@mkg20001
feat: Add /p2p-stardust
efd8634 
This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference
jacobheun
jacobheun approved these changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. This has been added to multicodec and multiaddr tables.

Commitlint is the only thing that's failing, because it doesn't like sentence case, ie feat: Add /p2p-stardust vs feat: add /p2p-stardust.

@mkg20001
Copy link
Contributor Author

Commitlint is the only thing that's failing, because it doesn't like sentence case, ie feat: Add /p2p-stardust vs feat: add /p2p-stardust.

Interesting to know why commit message case gets linted in the first place. I mean what's the difference? Honestly if it's not screaming in uppercase I don't see any. Could as well be Feat: Add /p2p-stardust, same thing

@jacobheun
Copy link
Contributor

Right now aegir is using @commitlint/config-conventional, and sentence case is on by default. Worth discussing in the aegir repo. Consistency of the changelog is really the biggest pro for it.

I normally just squash the commits and change the wording to resolve this for master.

@mkg20001 mkg20001 mentioned this pull request Jan 13, 2019
Closed
@mkg20001
Copy link
Contributor Author

see ipfs/aegir#318
Could you squash this one then?

@jacobheun
Copy link
Contributor

see ipfs/aegir#318

👍

Could you squash this one then?

I'm not currently a maintainer for this, so I will leave merging to @vmx or @victorb, as they're also needed for release.

@mkg20001 mkg20001 mentioned this pull request Jan 18, 2019
Closed
@mkg20001
Copy link
Contributor Author

@vmx Could you review and merge this?

@vmx vmx merged commit 54e6837 into multiformats:master Jan 25, 2019
@vmx
Copy link
Member

vmx commented Jan 25, 2019

@mkg20001 Merged and released.

@vmx vmx mentioned this pull request Jan 25, 2019
Merged
@mkg20001 mkg20001 deleted the patch-1 branch January 25, 2019 15:50
mkg20001 added a commit to mkg20001/js-mafmt that referenced this pull request Jan 25, 2019
@mkg20001
feat: Add /p2p-stardust
ebaa240 
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference

Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
mkg20001 added a commit to mkg20001/js-mafmt that referenced this pull request Jan 25, 2019
@mkg20001
feat: Add /p2p-stardust
386049c 
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference

Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
mkg20001 added a commit to mkg20001/js-mafmt that referenced this pull request Jan 25, 2019
@mkg20001
feat: add /p2p-stardust
b7a4387 
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference

Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
vasco-santos pushed a commit to multiformats/js-mafmt that referenced this pull request Feb 7, 2019
@mkg20001 @vasco-santos
feat: add /p2p-stardust (#35)
9b0c199 
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference

Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkg20001 @jacobheun @vmx