This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
fix: return Uint8Arrays #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
This looks good to me (assuming we can work out introduces circular dependency that ipfs/js-ipfs-utils#55 introduces)
BREAKING CHANGE: - node `Buffer`s are not returned any more, only `Uint8Array`s
achingbrain
force-pushed
the
fix/return-uint8arrays
branch
from
c5eef5b
to
7eecbf2
Compare
|
I've restored the |
vmx
approved these changes
Jul 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
Uint8Arrays instead of nodeBuffers.BREAKING CHANGE:
Buffers are not returned any more, onlyUint8Arrays