feat!: Make link.toJSON return a DAG-JSON link #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeal
approved these changes
Dec 13, 2022
|
Mind if we push this to January? Rod is off for the next few weeks and it'd be good to get his input. |
rvagg
approved these changes
Jan 2, 2023
achingbrain
added a commit
to achingbrain/js-libp2p-noise
that referenced
this pull request
Jan 6, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.
achingbrain
added a commit
to achingbrain/gossipsub-js
that referenced
this pull request
Jan 6, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jan 6, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
4 tasks
wemeetagain
pushed a commit
to ChainSafe/js-libp2p-noise
that referenced
this pull request
Jan 6, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.
wemeetagain
pushed a commit
to ChainSafe/js-libp2p-gossipsub
that referenced
this pull request
Jan 6, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. The code changed is not used by this module so there's not a lot of changes here, but this should still go out as a major because the interface versions have changed.
This was referenced Jan 6, 2023
achingbrain
added a commit
to libp2p/js-libp2p-daemon
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain
pushed a commit
to libp2p/interop
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to ipfs/js-datastore-pubsub
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) to the return type of the `.toJSON` method of the `CID` class so update all deps using multiformats to the latest version.
achingbrain
added a commit
to ipfs/js-datastore-pubsub
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to ipfs/js-ipfs-bitswap
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to ipfs/js-ipfs-bitswap
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Jan 7, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
achingbrain
added a commit
to achingbrain/js-dag-jose
that referenced
this pull request
Jan 9, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. BREAKING CHANGE: the CID class exposed by the types of this module now comes from `multiformats@v11.x.x`
9 tasks
achingbrain
added a commit
to achingbrain/js-dag-jose
that referenced
this pull request
Jan 9, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. BREAKING CHANGE: the CID class exposed by the types of this module now comes from `multiformats@v11.x.x`
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Jan 9, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version.
ukstv
pushed a commit
to ceramicnetwork/js-dag-jose
that referenced
this pull request
Jan 11, 2023
`multiformats@11.x.x` shipped with a [breaking change](multiformats/js-multiformats#230) so update all deps using multiformats to the latest version. BREAKING CHANGE: the CID class exposed by the types of this module now comes from `multiformats@v11.x.x`
achingbrain
added a commit
to ipfs/js-kubo-rpc-client
that referenced
this pull request
Jan 13, 2023
Multiformats@11.x.x shipped with a [breaking change to the CID class](multiformats/js-multiformats#230). This change updates all dependencies to use multiformats@11.x.x. BREAKING CHANGE: instances of the CID class returned by this module are now from multiformats@11.x.x Co-authored-by: achingbrain <alex@achingbrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes toJSON implementation of the CID so it returns Link in DAG-JSON format as opposed to object with Uint8Array which gets munged with
JSON.stringifyFixes #228