add a new code point for QUIC v1 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
requested changes
Nov 8, 2022
protocols.csv
Outdated
| @@ -23,9 +23,10 @@ code, size, name, comment | |||
| 448, 0, tls, Transport Layer Security | |||
| 449, V, sni, Server Name Indication RFC 6066 § 3 | |||
| 454, 0, noise, | |||
| 460, 0, quic, | |||
| 460, 0, quic-draft29, | |||
There was a problem hiding this comment.
Let's not make this rename change yet, because I think it may break parsing existing strings.
There was a problem hiding this comment.
Reverted this change.
MarcoPolo
approved these changes
Nov 11, 2022
protocols.csv
Outdated
| @@ -23,9 +23,10 @@ code, size, name, comment | |||
| 448, 0, tls, Transport Layer Security | |||
| 449, V, sni, Server Name Indication RFC 6066 § 3 | |||
| 454, 0, noise, | |||
| 460, 0, quic, | |||
| 460, 0, quic, | |||
There was a problem hiding this comment.
Did the formatting break?
There was a problem hiding this comment.
Yes. Editors break it all the time, since we're using tabs, and many editors convert those to spaces (including the built-in GitHub editor).
marten-seemann
force-pushed
the
quic-v1
branch
from
ba7dbc3
to
6ddfc21
Compare
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after multiformats/multicodec#298.