Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allocating inline IPLD multiformats #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Jun 17, 2023

We've talked about this informally for a while, I'd like to start experimenting with it but I want to make sure we get low numbers allocated to basic inline IPLD types.

@mikeal mikeal requested review from rvagg and vmx as code owners June 17, 2023 03:13
@mikeal mikeal changed the title feat: allocating inline IPLD multiformity feat: allocating inline IPLD multiformats Jun 17, 2023
@mikeal
Copy link
Contributor Author

mikeal commented Jun 17, 2023

We may also want to allocate uint8, uint16, and uint32 multiformats for when we need to do fixed length number encodings.

@rvagg
Copy link
Member

rvagg commented Jun 19, 2023

bit of a can of worms here if we start adding all the possible types in the single byte range - various string encodings, float encodings, all the ints and their endianness forms; so maybe this should be done in the two-byte range so we can add whatever people want?

@vmx
Copy link
Member

vmx commented Jun 19, 2023

I don't know what inline IPLD is used for. Is the idea to use it inside CIDs?

I'm with @rvagg here. Those experimental things belong in the >=2 bytes range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants