Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Bump version to v0.15.0 and add changelog entries #58

Merged
merged 1 commit into from
May 10, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 6, 2022

Follow up to #53 and #56.

@mxinden mxinden requested review from vmx and dignifiedquire May 6, 2022 10:54
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it is not actually a breaking change, is it?

@mxinden
Copy link
Member Author

mxinden commented May 6, 2022

lgtm, but it is not actually a breaking change, is it?

In case a user exhaustively matches on Protocol, compilation will fail due to the new variant Protocol::Noise.

@dignifiedquire
Copy link
Member

then maybe add non_exhaustive to the enzm for easier additions in the future?

@mxinden
Copy link
Member Author

mxinden commented May 6, 2022

then maybe add non_exhaustive to the enzm for easier additions in the future?

I would argue that as a downstream user I would appreciate the breaking change in Protocol, i.e. I would appreciate to be notified of the change (additional variant) by the compiler. There are some downstream users who would want to make use of the new protocol, e.g. a Prometheus exporter which is tracking the observed protocols as a metric.

@mxinden mxinden merged commit 8a4bd49 into multiformats:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants