Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add quic-v1 codepoint #64

Merged
merged 3 commits into from
Nov 13, 2022
Merged

*: Add quic-v1 codepoint #64

merged 3 commits into from
Nov 13, 2022

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Nov 11, 2022

Add QuicV1 codepoint to represent QUIC Version 1 / RFC 9000. See multiformats/multiaddr#145 for motivation.

To be merged after multiformats/multicodec#298.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry. Otherwise looks good to me. Thanks @elenaf9!

@@ -40,10 +40,10 @@ use multiaddr::{Multiaddr, multiaddr};

let address = "/ip4/127.0.0.1/tcp/1234".parse::<Multiaddr>().unwrap();
// or with a macro
let other = multiaddr!(Ip4([127, 0, 0, 1]), Udp(10500u16), Quic);
let other = multiaddr!(Ip4([127, 0, 0, 1]), Udp(10500u16), QuicV1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

tests/lib.rs Outdated Show resolved Hide resolved
@@ -133,6 +133,7 @@ impl Arbitrary for Proto {
Proto(Onion3((a, std::cmp::max(1, u16::arbitrary(g))).into()))
}
25 => Proto(Tls),
26 => Proto(QuicV1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing some protocols, see #65. Though that is out of scope for this pull request.

@elenaf9 elenaf9 requested a review from mxinden November 12, 2022 16:04
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thanks!

@mxinden mxinden merged commit 012af76 into multiformats:master Nov 13, 2022
@elenaf9 elenaf9 deleted the quic-v1 branch November 13, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants