Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add /webrtc protocol (browser-to-browser) #79

Closed
wants to merge 3 commits into from

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 17, 2023

No description provided.

@mxinden
Copy link
Member Author

mxinden commented Mar 19, 2023

Should we introduce this in the version after #78? The version that includes #78 only would then error on /webrtc instead of interpreting it as the browser-to-browser protocol. Might prevent some confusion.

@thomaseizinger
Copy link
Contributor

Should we introduce this in the version after #78? The version that includes #78 only would then error on /webrtc instead of interpreting it as the browser-to-browser protocol. Might prevent some confusion.

It is frustrating to release so many breaking changes but I don't think there is much choice now that the decision has been made.

@@ -1,3 +1,10 @@
# 0.19.0 - unreleased
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this pull request should not be included in the next breaking change, i.e. v0.18.0, but instead in the one right after, i.e. v0.19.0.

Rational:

  • v0.18.0 removes Protocol::WebRTC in favor of Protocol::WebRTCDirect.
  • This pull request re-introduces Protocol::WebRTC.
  • When this pull request is included in v0.18.0, users won't notice the repurpose of Protocol::WebRTC.

@mxinden mxinden marked this pull request as draft April 12, 2023 13:29
@mxinden
Copy link
Member Author

mxinden commented Apr 12, 2023

Moving to draft in order to not include in v0.18.0.

@jxs
Copy link
Contributor

jxs commented Sep 6, 2024

superseeded by #110

@jxs jxs closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants