-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviour of some OOP methods depend on min client version setting #1240
Comments
I think that OOP functions should always return vectors, and if we make a mistake, it needs to be fixed.
Why does it do this? Maybe I've missed a page or issue that documents/discusses this behaviour, but if it overrides whatever is defined in the |
Fwiw, there's nothing on the wiki that actually documents that OOP functions need to return vectors, but I think most people assume that it does? We should document that convention somewhere. In this case, I don't think there's anything we can do here except let those scripts break. If we had a way to track statistics we could make a more informed decision |
The effective min client requirement increases because the newer obsfucation methods need a higher client version. I guess what we need is the ability to check the declared min client requirement in meta.xml |
I've investigated further: Adding the ability for the client to check for the declared min client requirement needs a server side change. After that, a resource which uses any client function introduced after 1.5.6 will get a change in behaviour of Also, resources which use later functions with missing version requirements get a nag warning to use the In summary, I think we should try to remove the link to the min client requirement. I also think we should be brave now and consider something drastic which will eventually be better.
|
I vote for option 1, we frequently stagnate on issues like this for compatibility sake, but to simplify this entire issue, just switch to Vector3. |
Renaming shows a useful message but confusing since it goes against convention I'd say #1 with vectors too |
I agree with that 👍 |
The following OOP methods change their behaviour depending on the min client version setting. The min client requirement can change for various reasons (e.g. compiling) and therefore cause the script to break.
The text was updated successfully, but these errors were encountered: