Use enum classes for BitStream #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Oct 20, 2020
|
I advise no one to use the latest nightly, as this change seems to have broken connecting to servers:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows for querying BitStream compatibility by doing (for example)
bitStream.Can(eBitStreamVersion::FakeLagCommand)instead of getting the number and doing comparisons. You just need to add to the enum list.I propose that all future code uses this system as much as possible, instead of doing
GetVersion.There is a second pull request ready that applies the use of this feature to every change since the release of 1.5. I'll submit that pull request if/once this one merges.
Note: this pull request also increments the BitStream version. This is harmless, right?