Pusher subscription error for private and public channel fixed 🐛 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rahulhaque I'll look into it and test it as well .. thanks for your contribution |
|
@munafio thank you for your consideration. Sorry for the late reply. I also think this PR should be stale for now. I have been keeping an eye on the pusher-php-client and have a feeling this issue should be solved by the respective servers (e.g. soketi, laravel reverb etc.). Can't say anything for sure at the moment. I will close the PR when any update arrives. Here is a code that made me comment this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen this PR #280 rejected before which hard coded the channel name. I have taken a different approach that adheres to the Pusher protocol standard. I have tested this solution in both Soketi and Pusher sandbox environments, and it works seamlessly in both cases. Please, see if you find any issue with this approach.