a bug when using closeDrawerAnimated:velocity:animationOptions:completion: #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanOne
added a commit
to BryanOne/MMDrawerController
that referenced
this pull request
Aug 6, 2013
BryanOne
added a commit
to BryanOne/MMDrawerController
that referenced
this pull request
Aug 6, 2013
kcharwood
added a commit
that referenced
this pull request
Aug 12, 2013
kcharwood
pushed a commit
that referenced
this pull request
Aug 12, 2013
|
Took in @kobe9009's fix, and applied it to the open drawer state as well. Also, applied the completion block. |
|
Yeah this looks fine. |
kcharwood
added a commit
that referenced
this pull request
Aug 13, 2013
a bug when using closeDrawerAnimated:velocity:animationOptions:completion:
|
Thanks for the patch @kobe9009 🍻 |
|
You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if closeAnimation is running,then I call this method again, the sider viewcontroller will become black
in my case, this method will call sencond time through tap gesture
I will send a pullrequest to fix this case, hope it can help~thanks