Skip to content

Commit

Permalink
Merge pull request expressjs#2008 from agchou/clean-up-code
Browse files Browse the repository at this point in the history
some code clean up
  • Loading branch information
jonathanong committed Mar 27, 2014
2 parents 0120874 + 06dcb22 commit 2e830ff
Show file tree
Hide file tree
Showing 42 changed files with 149 additions and 143 deletions.
20 changes: 10 additions & 10 deletions examples/auth/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
* Module dependencies.
*/

var express = require('../..')
, hash = require('./pass').hash
, bodyParser = require('body-parser')
, cookieParser = require('cookie-parser')
, session = require('express-session')
var express = require('../..');
var hash = require('./pass').hash;
var bodyParser = require('body-parser');
var cookieParser = require('cookie-parser');
var session = require('express-session');

var app = module.exports = express();

Expand All @@ -24,8 +24,8 @@ app.use(session());
// Session-persisted message middleware

app.use(function(req, res, next){
var err = req.session.error
, msg = req.session.success;
var err = req.session.error;
var msg = req.session.success;
delete req.session.error;
delete req.session.success;
res.locals.message = '';
Expand Down Expand Up @@ -65,7 +65,7 @@ function authenticate(name, pass, fn) {
if (err) return fn(err);
if (hash == user.hash) return fn(null, user);
fn(new Error('invalid password'));
})
});
}

function restrict(req, res, next) {
Expand Down Expand Up @@ -101,9 +101,9 @@ app.post('/login', function(req, res){
authenticate(req.body.username, req.body.password, function(err, user){
if (user) {
// Regenerate session when signing in
// to prevent fixation
// to prevent fixation
req.session.regenerate(function(){
// Store the user's primary key
// Store the user's primary key
// in the session store to be retrieved,
// or in this case the entire user object
req.session.user = user;
Expand Down
9 changes: 6 additions & 3 deletions examples/big-view/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
/**
* Module dependencies.
*/

var express = require('../..')
, logger = require('morgan')
, app = express();
var express = require('../..');
var logger = require('morgan');
var app = express();

app.set('views', __dirname);
app.set('view engine', 'jade');
Expand Down
1 change: 0 additions & 1 deletion examples/content-negotiation/db.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

var users = [];

users.push({ name: 'Tobi' });
Expand Down
12 changes: 6 additions & 6 deletions examples/content-negotiation/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
var express = require('../../')
, app = module.exports = express()
, users = require('./db');
var express = require('../../');
var app = module.exports = express();
var users = require('./db');

// so either you can deal with different types of formatting
// so either you can deal with different types of formatting
// for expected response in index.js
app.get('/', function(req, res){
res.format({
Expand All @@ -21,7 +21,7 @@ app.get('/', function(req, res){
json: function(){
res.json(users);
}
})
});
});

// or you could write a tiny middleware like
Expand All @@ -32,7 +32,7 @@ function format(path) {
var obj = require(path);
return function(req, res){
res.format(obj);
}
};
}

app.get('/users', format('./users'));
Expand Down
1 change: 0 additions & 1 deletion examples/cookie-sessions/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

/**
* Module dependencies.
*/
Expand Down
14 changes: 6 additions & 8 deletions examples/cookies/app.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@

/**
* Module dependencies.
*/

var express = require('../../')
, app = module.exports = express()
, favicon = require('static-favicon')
, logger = require('morgan')
, cookieParser = require('cookie-parser')
, bodyParser = require('body-parser')

var express = require('../../');
var app = module.exports = express();
var favicon = require('static-favicon');
var logger = require('morgan');
var cookieParser = require('cookie-parser');
var bodyParser = require('body-parser');

// add favicon() before logger() so
// GET /favicon.ico requests are not
Expand Down
10 changes: 5 additions & 5 deletions examples/cors/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
* Module dependencies.
*/

var express = require('../..')
, logger = require('morgan')
, app = express()
, bodyParser = require('body-parser')
, api = express();
var express = require('../..');
var logger = require('morgan');
var app = express();
var bodyParser = require('body-parser');
var api = express();

// app middleware

Expand Down
9 changes: 4 additions & 5 deletions examples/downloads/app.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@

/**
* Module dependencies.
*/

var express = require('../../')
, app = module.exports = express();
var express = require('../../');
var app = module.exports = express();

app.get('/', function(req, res){
res.send('<ul>'
Expand All @@ -16,8 +15,8 @@ app.get('/', function(req, res){
// /files/* is accessed via req.params[0]
// but here we name it :file
app.get('/files/:file(*)', function(req, res, next){
var file = req.params.file
, path = __dirname + '/files/' + file;
var file = req.params.file;
var path = __dirname + '/files/' + file;

res.download(path);
});
Expand Down
1 change: 0 additions & 1 deletion examples/ejs/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

/**
* Module dependencies.
*/
Expand Down
10 changes: 5 additions & 5 deletions examples/error-pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
* Module dependencies.
*/

var express = require('../../')
, app = module.exports = express()
, logger = require('morgan')
, favicon = require('static-favicon')
, silent = 'test' == process.env.NODE_ENV;
var express = require('../../');
var app = module.exports = express();
var logger = require('morgan');
var favicon = require('static-favicon');
var silent = 'test' == process.env.NODE_ENV;

// general config
app.set('views', __dirname + '/views');
Expand Down
9 changes: 4 additions & 5 deletions examples/error/index.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@

/**
* Module dependencies.
*/

var express = require('../../')
, logger = require('morgan')
, app = module.exports = express()
, test = app.get('env') == 'test';
var express = require('../../');
var logger = require('morgan');
var app = module.exports = express();
var test = app.get('env') == 'test';

if (!test) app.use(logger('dev'));

Expand Down
8 changes: 4 additions & 4 deletions examples/expose-data-to-client/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

var express = require('../..')
, logger = require('morgan')
, app = express();
var express = require('../..');
var logger = require('morgan');
var app = express();

app.set('view engine', 'jade');
app.set('views', __dirname + '/views');
Expand All @@ -21,7 +21,7 @@ User.prototype.toJSON = function(){
return {
id: this.id,
name: this.name
}
};
};

app.use(logger('dev'));
Expand Down
1 change: 0 additions & 1 deletion examples/hello-world/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

var express = require('../../');

var app = express();
Expand Down
1 change: 0 additions & 1 deletion examples/jade/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

/**
* Module dependencies.
*/
Expand Down
15 changes: 7 additions & 8 deletions examples/markdown/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@

/**
* Module dependencies.
*/

var express = require('../..')
, fs = require('fs')
, md = require('marked').parse;
var express = require('../..');
var fs = require('fs');
var md = require('marked').parse;

var app = module.exports = express();

Expand All @@ -18,13 +17,13 @@ app.engine('md', function(path, options, fn){
var html = md(str);
html = html.replace(/\{([^}]+)\}/g, function(_, name){
return options[name] || '';
})
});
fn(null, html);
} catch(err) {
fn(err);
}
});
})
});

app.set('views', __dirname + '/views');

Expand All @@ -33,11 +32,11 @@ app.set('view engine', 'md');

app.get('/', function(req, res){
res.render('index', { title: 'Markdown Example' });
})
});

app.get('/fail', function(req, res){
res.render('missing', { title: 'Markdown Example' });
})
});

if (!module.parent) {
app.listen(3000);
Expand Down
11 changes: 5 additions & 6 deletions examples/multipart/index.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@

/**
* Module dependencies.
*/

var express = require('../..')
, bodyParser = require('body-parser')
, format = require('util').format;
var express = require('../..');
var bodyParser = require('body-parser');
var format = require('util').format;

var app = module.exports = express()
var app = module.exports = express();

app.use(bodyParser())
app.use(bodyParser());

app.get('/', function(req, res){
res.send('<form method="post" enctype="multipart/form-data">'
Expand Down
1 change: 0 additions & 1 deletion examples/mvc/controllers/main/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

exports.index = function(req, res){
res.redirect('/users');
};
3 changes: 3 additions & 0 deletions examples/mvc/controllers/pet/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Module dependencies.
*/

var db = require('../../db');

Expand Down
3 changes: 3 additions & 0 deletions examples/mvc/controllers/user-pet/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Module dependencies.
*/

var db = require('../../db');

Expand Down
5 changes: 4 additions & 1 deletion examples/mvc/controllers/user/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Module dependencies.
*/

var db = require('../../db');

Expand All @@ -12,7 +15,7 @@ exports.before = function(req, res, next){
// found it, move on to the routes
next();
});
}
};

exports.list = function(req, res, next){
res.render('list', { users: db.users });
Expand Down
1 change: 0 additions & 1 deletion examples/mvc/db.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

// faux database

var pets = exports.pets = [];
Expand Down
4 changes: 4 additions & 0 deletions examples/mvc/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/**
* Module dependencies.
*/

var express = require('../..');
var logger = require('morgan');
var session = require('express-session');
Expand Down
19 changes: 11 additions & 8 deletions examples/mvc/lib/boot.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
/**
* Module dependencies.
*/

var express = require('../../..')
, fs = require('fs');
var express = require('../../..');
var fs = require('fs');

module.exports = function(parent, options){
var verbose = options.verbose;
fs.readdirSync(__dirname + '/../controllers').forEach(function(name){
verbose && console.log('\n %s:', name);
var obj = require('./../controllers/' + name)
, name = obj.name || name
, prefix = obj.prefix || ''
, app = express()
, method
, path;
var obj = require('./../controllers/' + name);
var name = obj.name || name;
var prefix = obj.prefix || '';
var app = express();
var method;
var path;

// allow specifying the view engine
if (obj.engine) app.set('view engine', obj.engine);
Expand Down
9 changes: 4 additions & 5 deletions examples/online/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

// first:
// $ npm install redis online
// $ redis-server
Expand All @@ -7,10 +6,10 @@
* Module dependencies.
*/

var express = require('../..')
, online = require('online')
, redis = require('redis')
, db = redis.createClient();
var express = require('../..');
var online = require('online');
var redis = require('redis');
var db = redis.createClient();

// online

Expand Down
Loading

0 comments on commit 2e830ff

Please sign in to comment.