implement openssh config behavior to handle append, prepend and removal of algorithms #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation. JEP 329 implements an RFC-7539 version of ChaCha20 (96 bit nonce + 32 bit counter), while OpenSSH uses a different variant of ChaCha20 (64 bit nonce + 64 bit counter). Switching to Bouncy Castle's ChaChaEngine eliminates dependence upon JEP 329's implementation working for the non RFC-7539 version of ChaCha20 that OpenSSH utilizes.
|
It would be nice to have this option also for the configuration with java system properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a user was facing the issue in #103 I implemented the openssh config file interpretation, so that Jsch users can use openssh config file without modifiying them. As mentioned in ssh_config man page, the
+means appending to the comma separated list,^means to prepend and-means to remove from the list of algorithms.