P11 char Qt #460
Open
P11 char Qt #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 10, 2024 12:30
…on in PR#966 mxcubecore
…b is not available.
…NState (PR#966 mxcubecore)
…ube designer mode
…o create P11 mach info brick:wq
beteva
reviewed
Oct 1, 2024
Comment on lines
+131
to
+132
| # Check if machine current is <= 99, change color | ||
| if current_value != "N/A" and float(current_value) <= 99: |
There was a problem hiding this comment.
Why 99? Can it be configurable or even better, got from the HO as limits?
beteva
reviewed
Oct 1, 2024
| Args: | ||
| limits (tuple): A tuple containing the minimum and maximum transmission limits. | ||
| """ | ||
| if limits and limits[0] is not None and limits[1] is not None: |
There was a problem hiding this comment.
Maybe you could simply check if limits and None not in limits:
beteva
reviewed
Oct 1, 2024
| """ | ||
| if limits: | ||
| if limits and limits[0] is not None and limits[1] is not None: |
There was a problem hiding this comment.
Maybe you could simply check if limits and None not in limits:
beteva
reviewed
Oct 1, 2024
| Args: | ||
| limits (tuple): A tuple containing the minimum and maximum transmission limits. | ||
| """ | ||
| if limits and limits[0] is not None and limits[1] is not None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated qt parts in sync with corresponding p11_char branch in mxcubecore p11_char.