Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field Component #26

Merged
merged 21 commits into from
May 28, 2020
Merged

Field Component #26

merged 21 commits into from
May 28, 2020

Conversation

mxdi9i7
Copy link
Owner

@mxdi9i7 mxdi9i7 commented May 26, 2020

No description provided.

@mxdi9i7 mxdi9i7 changed the title WIP: Field Component Field Component May 27, 2020
LIUSHANYIN
LIUSHANYIN previously approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@LIUSHANYIN LIUSHANYIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trista8130
trista8130 previously approved these changes May 27, 2020
View reviewed changes
@z695245771
Copy link
Collaborator

image

image
no background color in old page

@z695245771
Copy link
Collaborator

image
There should only be 5 px margin after icon, but there is 5 more pixel after icon container here

@z695245771
Copy link
Collaborator

Screen Shot 2020-05-27 at 1 08 47 PM

@z695245771
Copy link
Collaborator

Screen Shot 2020-05-27 at 1 16 56 PM
why this popup twice

@z695245771
Copy link
Collaborator

Screen Shot 2020-05-27 at 1 21 43 PM
cant put punctuation marks at all, like comma

@z695245771
Copy link
Collaborator

Screen Shot 2020-05-27 at 1 25 39 PM

@z695245771
Copy link
Collaborator

Screen Shot 2020-05-27 at 1 28 50 PM

@z695245771
Copy link
Collaborator

autoresize doesnt work too

@mxdi9i7
Copy link
Owner Author

mxdi9i7 commented May 27, 2020 •
edited
Loading

autoresize doesnt work too

Autoresize is a TODO, not implemented in this PR @z695245771

WillHHH
WillHHH previously approved these changes May 28, 2020
View reviewed changes
@z695245771
Copy link
Collaborator

conflict dude

@mxdi9i7 mxdi9i7 dismissed stale reviews from WillHHH, trista8130, and LIUSHANYIN via 17a500b May 28, 2020 23:27
@mxdi9i7 mxdi9i7 merged commit d080634 into master May 28, 2020
@mxdi9i7 mxdi9i7 deleted the peterz/field branch May 28, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LIUSHANYIN LIUSHANYIN LIUSHANYIN left review comments

@WillHHH WillHHH WillHHH left review comments

@trista8130 trista8130 trista8130 left review comments

@ssysm ssysm Awaiting requested review from ssysm

@z695245771 z695245771 Awaiting requested review from z695245771

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mxdi9i7 @z695245771 @LIUSHANYIN @WillHHH @trista8130