Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar Components #8

Merged
merged 5 commits into from
May 25, 2020
Merged

Navbar Components #8

merged 5 commits into from
May 25, 2020

Conversation

mxdi9i7
Copy link
Owner

@mxdi9i7 mxdi9i7 commented May 24, 2020

No description provided.

@mxdi9i7 mxdi9i7 changed the base branch from peterz/icons to master May 24, 2020 21:37
@z695245771
Copy link
Collaborator

image
image
font weight is different from original vent

LIUSHANYIN
LIUSHANYIN reviewed May 24, 2020
View reviewed changes
Copy link
Collaborator

@LIUSHANYIN LIUSHANYIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z695245771
Copy link
Collaborator

image
image

There is border-bottom in their original page

@WillHHH
Copy link
Collaborator

WillHHH commented May 24, 2020

image
image
font weight is different from original vent

I think so, a little bit thin for me

@mxdi9i7 mxdi9i7 merged commit 2259026 into master May 25, 2020
@ssysm ssysm deleted the peterz/navbar branch May 26, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LIUSHANYIN LIUSHANYIN LIUSHANYIN left review comments

@WillHHH WillHHH WillHHH left review comments

@trista8130 trista8130 trista8130 approved these changes

@z695245771 z695245771 Awaiting requested review from z695245771

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mxdi9i7 @z695245771 @WillHHH @LIUSHANYIN @trista8130