Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vendir authentication via the enviroment #35

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: Add vendir authentication via the enviroment #35

merged 1 commit into from
Jul 26, 2023

Conversation

fritzduchardt
Copy link
Collaborator

No description provided.

@fritzduchardt fritzduchardt changed the base branch from main to release-2.0 July 20, 2023 14:45
@fritzduchardt fritzduchardt changed the title Feature add vendir auth feat: Add vendir authentication via the enviroment Jul 20, 2023
@fritzduchardt fritzduchardt force-pushed the feature_add_vendir_auth branch 3 times, most recently from 967436e to 118ae37 Compare July 21, 2023 05:46
@Zebradil
Copy link
Member

I'm looking into that.

Zebradil
Zebradil reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@Zebradil Zebradil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But could you also provide a bit of documentation for that? Maybe in a separate PR. Or create an issue for that with the main points, then we move to the readme.

@fritzduchardt
Copy link
Collaborator Author

LGTM.

But could you also provide a bit of documentation for that? Maybe in a separate PR. Or create an issue for that with the main points, then we move to the readme.

Sure thing.

@fritzduchardt fritzduchardt merged commit fe661ef into release-2.0 Jul 26, 2023
3 checks passed
@fritzduchardt fritzduchardt deleted the feature_add_vendir_auth branch July 26, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zebradil Zebradil Zebradil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzduchardt @Zebradil