Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylbo/save selection #120

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Pylbo/save selection #120

merged 4 commits into from
Jan 31, 2023

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Jan 31, 2023

PR description

When interactively viewing a spectrum with Pylbo, selected eigenvalues and their eigenfunctions (or indices) can be saved to a .npy file for further analysis.

New features

Pylbo

  • Introduction of optional argument display_info in the load and load_series functions to turn of writing datfile information to terminal.
  • Keypress function _save_eigenvalue_selection to save interactively selected eigenvalues and their eigenfunctions to a .npy file.
  • Keypress function _save_selection_indices to save the indices of interactively selected eigenvalues to a .npy file.

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@jordidj jordidj added feature Implementation of a new feature pylbo Affects the post-processing framework Pylbo labels Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #120 (1b22278) into develop (878ca67) will decrease coverage by 0.37%.
The diff coverage is 24.39%.

❗ Current head 1b22278 differs from pull request most recent head 771164d. Consider uploading reports for the commit 771164d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
- Coverage    89.30%   88.94%   -0.37%     
===========================================
  Files          129      129              
  Lines         7481     7515      +34     
===========================================
+ Hits          6681     6684       +3     
- Misses         800      831      +31     
Flag Coverage Δ
legolas 90.38% <ø> (ø)
pylbo 86.53% <24.39%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes added this to the Legolas 2.0 milestone Jan 31, 2023
@n-claes n-claes merged commit 2558bc4 into develop Jan 31, 2023
@n-claes n-claes deleted the pylbo/save_selection branch January 31, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a new feature pylbo Affects the post-processing framework Pylbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants