Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for 1D models + thermal conduction in hydro #125

Merged
merged 12 commits into from
Mar 29, 2023
Merged

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Mar 14, 2023

PR description

Adds a hd-1d physics type, support for isotropic thermal conduction in HD and a custom heating term.

New features

Legolas

  • a new hd-1d physics type for 1D hydro models along a fixed field line
  • new option in the parfile to enable custom heating
  • option to disable forced thermal balance, allowing for runs in non-thermal equilibrium
  • option to set units based on numberdensity, length and temperature

Bugfixes

Legolas

  • fixed crash when thermal conduction was enabled in hydro (due to division by B0^2)

Pylbo

  • fixed issue when interactively plotting derived eigenfunctions if there is only 1 element in the state vector (i.e. only S when in 1D)

TODO

  • add unit numberdensity support to the parfile

@n-claes n-claes added bug Something isn't working feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas labels Mar 14, 2023
@n-claes n-claes added this to the Legolas 2.0 milestone Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #125 (a35eb30) into develop (ff5a017) will decrease coverage by 0.28%.
The diff coverage is 84.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    91.73%   91.45%   -0.28%     
===========================================
  Files          148      148              
  Lines         8223     8328     +105     
===========================================
+ Hits          7543     7616      +73     
- Misses         680      712      +32     
Flag Coverage Δ
legolas 93.15% <85.58%> (-0.43%) ⬇️
pylbo 88.49% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit b6c38ef into develop Mar 29, 2023
@n-claes n-claes deleted the feature/hydro_tc branch March 29, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant