Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for optional saving of background state #136

Merged
merged 6 commits into from
Apr 20, 2023

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Apr 20, 2023

PR description

This PR adds the option to disable saving the background to the datfile, which is useful to reduce the datfile size for high resolution parameter studies. Note that eg. continua, sound speed... can not be calculated in this case, appropriate errors will be thrown by Pylbo. This change modifies the datfile but is backwards compatible.

New features

Legolas

  • New option write_background = .false. in the savelist, which disables saving the background to the datfile.

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@n-claes n-claes added feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas tests-pylbo Modified or new pylbo tests pylbo-backend Under-the-hood changes to Pylbo labels Apr 20, 2023
@n-claes n-claes added this to the Legolas 2.0 milestone Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #136 (cf185e2) into develop (e98d984) will increase coverage by 0.03%.
The diff coverage is 97.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #136      +/-   ##
===========================================
+ Coverage    90.65%   90.68%   +0.03%     
===========================================
  Files          158      158              
  Lines         8899     8952      +53     
===========================================
+ Hits          8067     8118      +51     
- Misses         832      834       +2     
Flag Coverage Δ
legolas 93.11% <83.33%> (-0.03%) ⬇️
pylbo 86.33% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit 8b2bcad into develop Apr 20, 2023
@n-claes n-claes deleted the feature/write_equilibria branch April 20, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas pylbo-backend Under-the-hood changes to Pylbo tests-pylbo Modified or new pylbo tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant